[core] Fix the icon used when registering Pulsar as a file handler in Windows #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spiker985
approved these changes
Sep 3, 2023
|
Thanks a ton for the review @Spiker985! With your approval, and all tests passing, lets go ahead and merge this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if Pulsar is registered as a file handler in Windows, the icon used no longer exists since our rewriting of the
electron-builderprocess.This means that if Pulsar is then set as the application to open a specific file, after enabling
Register as file handlerin Pulsar's settings, that file will receive a blank icon, instead of the Pulsar logo.This PR resolves the icon path to one that we know exists on Windows, and should resolve this issue.
Resolves #662