Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] GitHub Actions: Don't sign macOS builds from forked repo PRs #698

Merged
merged 3 commits into from
Aug 31, 2023
Merged

[meta] GitHub Actions: Don't sign macOS builds from forked repo PRs #698

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f67985
Set `macOS` signing vars as dedicated step
confused-Techie Aug 30, 2023
c3bdd11
Conditional signing of macOS binaries
confused-Techie Aug 31, 2023
a93f1ca
Simplify comment
confused-Techie Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,11 @@ jobs:
yarn run build:apm

# macOS Signing Stuff
- name: Build Pulsar Binaries (macOS)
if: ${{ runner.os == 'macOS' }}
- name: Build Pulsar Binaries (macOS) (Signed)
if: ${{ runner.os == 'macOS' && github.event.pull_request.head.repo.full_name == 'pulsar-edit/pulsar' }}
# PRs generated from forks cannot access GitHub Secrets
# The empty string assignment of these values will cause macOS builds to fail
# So if the PR is a fork, we will still build, but will not sign.
env:
CSC_LINK: ${{ secrets.CSC_LINK }}
CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD }}
Expand All @@ -88,6 +91,15 @@ jobs:
retry_on: error
command: yarn dist

- name: Build Pulsar Binaries (macOS) (Unsigned)
if: ${{ runner.os == 'macOS' && github.event.pull_request.head.repo.full_name != 'pulsar-edit/pulsar' }}
uses: nick-fields/retry@943e742917ac94714d2f408a0e8320f2d1fcafcd
with:
timeout_minutes: 30
max_attempts: 3
retry_on: error
command: yarn dist

- name: Build Pulsar Binaries
if: ${{ runner.os != 'macOS' }}
uses: nick-fields/retry@943e742917ac94714d2f408a0e8320f2d1fcafcd
Expand Down