Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] Ensure Actions can upload Rolling Releases #695

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

confused-Techie
Copy link
Member

This PR increases the permissions of the actions to ensure it can write the new release for rolling releases

Copy link
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going a little fast around here at the moment to get things done in time, but I think this is good. 👍

@confused-Techie
Copy link
Member Author

Thanks @DeeDeeG

@confused-Techie confused-Techie merged commit f922b10 into master Aug 29, 2023
@confused-Techie confused-Techie deleted the grant-perms-to-action branch August 29, 2023 03:44
@DeeDeeG
Copy link
Member

DeeDeeG commented Aug 29, 2023

For posterity/documentation purposes: This token needed the contents: write permission for the Rolling repo we are publishing releases to. Per this documentation...

If you search in the page here for "release": https://docs.github.com/en/rest/overview/permissions-required-for-fine-grained-personal-access-tokens?apiVersion=2022-11-28#repository-permissions-for-contents

You can see managing releases is all handled under the contents permission, and making a new release or uploading binaries requires contents:write permission.

(Which, write is a superset of/also implies read, near as I can tell. You definitely can't make a token that has write without also granting read.)

And to clarify, if anyone needs to re-up the token and I'm not available, it just has to be a PAT token for an individual with write access to the rolling repo. Making it be one of the newer-style, fine-grained tokens is HIGHLY RECOMMENDED, scoped to just the rolling releases repo and with only contents:write (and metadata:read, which is apparently mandatory). And I would specifically discourage using one of the old classic tokens for this purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants