Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autocomplete-plus] Suppress marked warnings #683

Conversation

savetheclocktower
Copy link
Contributor

Identify the Bug

When autocomplete-plus shows results, some warnings appear in the console about marked deprecations.

Description of the Change

This PR just makes the changes recommended in the warnings. The features in question aren’t features we need in this context.

Alternate Designs

One of them — adding IDs to headings — is something that we’ll probably need for markdown-preview, so we might consider installing the extra package for that. But we’ll never need the ability to mangle email addresses, so I’m looking forward to the next version of marked that’ll just remove that feature altogether and stop making us explicitly opt out of it.

Possible Drawbacks

Two extra lines of code? That’s all I can think of.

Verification Process

No real way to verify via a spec that a warning wasn’t emitted, but I’ve confirmed that the warnings don’t appear in the console now that I’ve added these settings.

Release Notes

  • Prevented warnings in the developer console from appearing when autocomplete suggestions are shown

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Super simple change, and whenever I saw those warnings could never be quite sure where they were coming from.
Reviewed what was needed to fix it at the time, just never investigated where to put it, so glad you've tracked it down and solved it! Thanks

@savetheclocktower savetheclocktower merged commit c7e2567 into pulsar-edit:master Aug 23, 2023
@savetheclocktower savetheclocktower deleted the suppress-marked-warnings-in-autocomplete branch August 23, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants