[autocomplete-plus] Suppress marked
warnings
#683
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
When
autocomplete-plus
shows results, some warnings appear in the console aboutmarked
deprecations.Description of the Change
This PR just makes the changes recommended in the warnings. The features in question aren’t features we need in this context.
Alternate Designs
One of them — adding IDs to headings — is something that we’ll probably need for
markdown-preview
, so we might consider installing the extra package for that. But we’ll never need the ability to mangle email addresses, so I’m looking forward to the next version ofmarked
that’ll just remove that feature altogether and stop making us explicitly opt out of it.Possible Drawbacks
Two extra lines of code? That’s all I can think of.
Verification Process
No real way to verify via a spec that a warning wasn’t emitted, but I’ve confirmed that the warnings don’t appear in the console now that I’ve added these settings.
Release Notes