bump actions/checkout to v3 #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
confused-Techie
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
This looks great! Thanks a ton @casswedson for your first time contribution! It's very much appreciated.
But yeah the changes here look great, and I'm providing a tentative approval conditionally on all tests passing, so I'll keep an eye on them.
(Also fair warning, some of the cirrus tests may fail once or twice, doesn't mean you did anything wrong, I'll rerun them if needed, or otherwise let you know if it's the result of this PR)
Thanks a ton for contributing and finding something like this that has been missed!
|
setup-node can also be updated and should Just Work:tm:. I could've sworn I bumped these, but that could've been on a different repo |
there are a bunch of deprecation warnings here about actions/checkout and actions/setup-node https://github.com/pulsar-edit/pulsar/actions/runs/5886138612 fix most of them by bumping checkout and setup-node to v3
casswedson
force-pushed
the
fix-warnings
branch
from
102239f to
42ad6bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
there are a bunch of deprecation warnings here about actions/checkout and
actions/setup-node
https://github.com/pulsar-edit/pulsar/actions/runs/5886138612
Description of the Change
fix most of them by bumping checkout to v3, I don't know why setup-
node@v2-beta is there so I am not changing it
Alternate Designs
Possible Drawbacks
Verification Process
Release Notes
bump actions/checkout to v3