Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppm: Update submodule to 49c8ced8f9552bb4aeb279130 #654

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

DeeDeeG
Copy link
Member

@DeeDeeG DeeDeeG commented Jul 22, 2023

Updating the ppm submodule

Updating the ppm submodule from 915cbf6e5f9ea1141ef5dcaf86343237e17bf380 to 49c8ced8f9552bb4aeb279130e20a491e653ab75. Comparison view on GitHub of the changes.

  • Adds ppm and ppm.cmd bins to complement existing apm and apm.cmd bins. Should help integrating a correctly named ppm binary/launcher onto the user's PATH for CLI usage in Windows, maybe it will make a meaningful difference in some other contexts as well.
  • Also updates some help text to correctly refer to or demonstrate 'ppm' commands, not 'apm' commands.
  • Some CI-only bumps of two GitHub Actions and adding testing on Node 18 (to complement existing testing on Node 14 and 16).

CHANGELOG

I added this stuff to the CHANGELOG.md as well, at least as pertains to this first step. There will probably be a lot of follow-up work making use of the new ppm and ppm.cmd bins in core repo that will be worth mentioning in the CHANGELOGs, but that stuff isn't done yet, so. We can decide what to write about it when more is said and done and/or when release time rolls around again.

Includes the following PRs from ppm repo:

DeeDeeG added 2 commits July 20, 2023 22:41
Adds 'ppm' bins to complement existing 'apm' bins.

Also updates some help text to refer to or demonstrate 'ppm' commands,
not 'apm' commands.
@DeeDeeG
Copy link
Member Author

DeeDeeG commented Jul 22, 2023

We have more follow-up stuff we can do with this, but I wanted to submit the ppm update on its own. We can evaluate follow-up stuff in separate PRs, IMO.

Also: I am kinda busy today/tomorrow and may be for the next week or so :/. So, this is what I can easily get done today amidst other things I am doing.

@@ -6,6 +6,18 @@

## [Unreleased]

- Added `ppm` and `ppm.cmd` binaries/launchers within ppm. This allows easier integration of correctly named binaries on more systems in more contexts (especially Windows). Existing `apm` and `apm.cmd` binaries/launchers are still there for the time being.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK if this note is too long, if someone wants to suggest shortened wording, go for it.

I may not be around to review any suggestions later today, tho.

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see us getting this update in! I honestly think the wording is totally fine here even if a bit verbose. But I'll wait to merge for anyone that wants to, to chime in on that sort of thing. Otherwise thanks for getting to this! And especially adding it all to the ChangeLog

@confused-Techie confused-Techie merged commit c90ffd2 into master Jul 25, 2023
@confused-Techie confused-Techie deleted the update-ppm-submodule-add-ppm-bins branch July 25, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants