deps: Update github package to v0.36.17-pretranspiled #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes updated Less syntax for Less 4.x compatibility
confused-Techie
approved these changes
Jul 16, 2023
There was a problem hiding this comment.
Approving, as the changes in this repo look solid. And as one of the authors of the changes being brought in by this, I know there should be zero things that cause breakage, and or cause any issues.
So lets get this merged quickly to let binary generating runs go ahead for the hotfix release
|
Also just wanna add fantastic write up for the pr description here @DeeDeeG |
Co-authored-by: confused-Techie <[email protected]>
This was referenced Jul 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping github package to fix the styling with Less 4
Includes updated Less syntax for Less 4.x compatibility
That is to say, this bump includes PR pulsar-edit/github#34.
As reported on Discord by @asiloisad, the CSS is a bit messed up in the github package in Pulsar v1.107.0, which was just released earlier today (Depending on your time zone).
This is due to a breaking change in Less 4.x, as introduced to Pulsar in pulsar-edit/less-cache#4 --> #611.
While good efforts were made to ensure this won't affect community packages, those measures don't apply to bundled packages. So, yeah, we missed github package. Now we have updated the syntax! Broken styling be gone.
The changes in github package should be fully back-compatible with older Less, since the now-required parentheses around division math
/expressions were always allowed they are only now becoming required. So don't fear upgrading to this version of the package, whoever might be on an older version of Pulsar out there...Credit
Thank you to @asiloisad for reporting the issue, helping us to resolve it and even help track down the particular affected parts of files, thank you @confused-Techie for immediately recognizing the source of the problem and discussing the fix, coordinating the fix and fixing up several of the files with the needed changes, and I @DeeDeeG also contributed some of the needed less syntax changes and tagging a new version of the github package with the needed pretranspilation steps, and now of course posting this PR...
Screenshots
Before (broken in Pulsar v1.107.0):
After (With fix):
Linked issues
Fixes: #638