[language-*]: Manual Spec Decaf (Part 1) #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* language-c * language-clojure * language-coffee-script * language-csharp * language-css * language-gfm * language-git * language-go
This reverts commit d51de56.
This reverts commit b40c1e3.
This reverts commit 39e5955.
This reverts commit 050f0c9.
This reverts commit d132564.
This reverts commit 3156dbf.
|
Since all tests are passing here, and these changes should result in zero changed logic or behavior, I'll go ahead and merge in a few days. Just giving the chance for anyone to speak out about changes not yet in an active PR for any of these tests, as I'd rather not make life harder for the folks working with our languages |
|
As promised, I think we are good to merge here. I'll go ahead and change the target branch and ensure tests are happy and things are conflict free before merging. But as this is 2 weeks old with zero changes to logic or functionality, I'll merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins to decaf the language specs.
Due to the sheer amount of them, it was a bit unrealistic to fit this all in one PR, so this PR tackles only a few of them, with the hopes that the rest can be touched in subsequent PRs.
Really the only work done for manual decaf here, was to remove implicit returns, since the syntax of tests is usually rather straightforward and generally doesn't end up with as much jank as source files.
The languages decafed in this PR are:
[1]: Seems CoffeeScript 1.x was better at keeping multiline tabs intact, meanwhile CoffeeScript 2.x tooling looses it. Manually adding back in the tabs when compared to CoffeeScript 1.x tooling output seems to have resolved the issue, while keeping the better decaf intact