Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency semver to v7.5.2 [SECURITY] #609

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 26, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
semver 7.3.8 -> 7.5.2 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2022-25883

Versions of the package semver before 7.5.2 are vulnerable to Regular Expression Denial of Service (ReDoS) via the function new Range, when untrusted user data is provided as a range.


Release Notes

npm/node-semver (semver)

v7.5.2

Compare Source

Bug Fixes

v7.5.1

Compare Source

Bug Fixes

v7.5.0

Compare Source

Features
Bug Fixes

v7.4.0

Compare Source

Features
Bug Fixes
Documentation

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@confused-Techie
Copy link
Member

Why would this not be included in #605 ? That was merged literally just today

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the API and our usage of semver within core, doesn't seem to have seen any changes.

As we currently only use semver within module-cache.js using the semver.Range class and semver.validRange() function, both of which still exist on the newest version, and don't seem to have any marked changes in usage since the last version we were using.

And since all tests are passing, I think we are good to go on this one, and I'll go ahead and approve

@renovate renovate bot changed the title Update dependency semver to v7.5.2 [SECURITY] Update dependency semver to v7.5.2 [SECURITY] - autoclosed Jun 26, 2023
@renovate renovate bot closed this Jun 26, 2023
@renovate renovate bot deleted the renovate/npm-semver-vulnerability branch June 26, 2023 13:29
@renovate renovate bot changed the title Update dependency semver to v7.5.2 [SECURITY] - autoclosed Update dependency semver to v7.5.2 [SECURITY] Jun 30, 2023
@renovate renovate bot reopened this Jun 30, 2023
@renovate renovate bot restored the renovate/npm-semver-vulnerability branch June 30, 2023 06:23
@renovate renovate bot force-pushed the renovate/npm-semver-vulnerability branch from 3233112 to 85e034b Compare June 30, 2023 06:23
Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved before, I'll approve again. Diff seems fine for our purposes, and tests are happy

@confused-Techie confused-Techie merged commit 5e71160 into master Jun 30, 2023
@confused-Techie confused-Techie deleted the renovate/npm-semver-vulnerability branch June 30, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant