Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump async to v3.2.4 #59

Merged
merged 3 commits into from
Sep 28, 2022
Merged

Bump async to v3.2.4 #59

merged 3 commits into from
Sep 28, 2022

Conversation

confused-Techie
Copy link
Member

@confused-Techie confused-Techie commented Sep 17, 2022

While bumping on main only gets us moderately more updated, there are many imports that also require bumps, that will provide us with modernity, as well as many many security advantages.

Since this PR doesn't address those security fixes, they will be left out.

Otherwise the additional repos should also receive async bumps, hopefully all to the same version:

  • fs-plus
  • fuzzy-finder
  • node-ls-archive (Also may need to switch to the repo version of this import, rather than NPM)
  • node-pathwatcher (Also may need to switch to the repo version of this import, rather than NPM)
  • settings-view
  • snippets
  • symbols-view

With these changes the editor was able to install, build, start, and run without issue.


EDIT:

Forget to mention that while bumping the version, some changes were made to our package.json metadata automatically, most notably removing a duplicate author field, and it re-arranged some dependencies, any dependency other than async that shows its been modified, has likely just been moved in its location on this PR, automatically by yarn.

@mauricioszabo
Copy link
Contributor

Merging master into this one to check if things keep working :)

@confused-Techie
Copy link
Member Author

Test look good here, except Windows which failed to install. But kinda par for the course with that OS. So otherwise looks good to me. I'll give you a second to double check if you wanna approve or merge @mauricioszabo

@mauricioszabo mauricioszabo merged commit 9f2500d into master Sep 28, 2022
@mauricioszabo mauricioszabo deleted the bump-async branch September 28, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants