Remove specific cinnamon condition

[mauricioszabo]

Recently, I changed my desktop env from KDE to Cinnamon. Pulsar was not loading with the message:

╰─>$ pulsar .
/usr/bin/pulsar: line 139: ${$ACTION_PATH}: bad substitution

Honestly, I don't know what does lines do, and it seem flaky anyway, so this fixes the issue.

[Daeraxa]

Where do you see this. I've been using it with cinnamon for ages and never seen this

[mauricioszabo]

@Daeraxa when trying to load pulsar from the command line - Ubuntu 22.04

[Daeraxa]

The deb version? Same as I run but never seen it on mint 21

[Spiker985]

Probably only a problem on a native nemo install

I believe it is used for the Open with Pulsar action

And this would be my bad, but should be able to be fixed simply by wrapping in double quotes

Edit: Would be fixed by removing the second $

Edit 2: The reason it's flaky, is because I didn't change the condition for matching to cinnamon, that was the way that the Atom team had matched it, rather than just checking that the value was literally the text they wanted. Might've been a sh -> bash thing.

And also that bit about the improper path for resources is also incorrect. If the file is included as part of our packaging, it would be correct

[mauricioszabo]

@Spiker985 removing the second $ does indeed fixes the issue, but I always get the error:

cp: cannot create regular file '/usr/share/nemo/actions/pulsar.nemo_action': Permission denied

So it's not perfect, and I honestly fail to see how that could even work (copying a file to a root-protected folder without sudo)