Properly localize Download/Stargazer Counts within settings-view
#526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting to the bottom of this issue, seems to stem from as soon as the backend migrated to the new package builder.
The backend now returns strings for both
stargazer_count
anddownloads
instead of integers.Meaning that when
settings-view
used:That
.toLocaleString()
would just return the same string it received, rather than operate on it. So that a string of1000
stayed as1000
rather than1,000
.So what I've done here is first parsed any strings on these values to integers, then we localize the value itself, to match with how the user expects in their region.
I've confirmed that attempting to convert any integers to an integer has no negative effects, so that when this is fixed on the backend (which it also should be) this solution will not cause any issues.
Really while I do plan on fixing it on the backend, it still makes sense to me to fix it here as well, to ensure we always show the user what they want to see.
So beyond that lets look at the before and after:
Before
After
Resolves #441