Bundle tree view #513
Merged
Bundle tree view #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
|
Alright, looks like all tests here are passing just as they should, so this one is good to go. Additionally, since I was able to comment out those two failing specs from this package, this is now the PR with our lowest amount of failing specs |
mauricioszabo
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the title says this PR bundles the core package
tree-view.The result of this PR should mean zero change in code or functionality for Pulsar, except that we as maintainers get to worry about one less repo.
A note, as we see on #511
tree-viewis one of the last three packages that contains failing tests.If all goes well on this PR I'll look at addressing those here, ideally fixing them, but alternatively may just comment them out.
Those changes, while not always the best to include in a PR with other purposes, as it's only two tests I'm hoping the change will not be significant. Even though, if it is I'll ensure to link the commit that touches tests, and does changes beyond bundling here.