Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency minimist [security] #502

Merged
merged 1 commit into from
Apr 29, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 18, 2023

Mend Renovate

This PR contains the following updates:

Package Change
minimist 0.0.8 -> 0.2.4
minimist 1.2.0 -> 1.2.6
minimist 1.2.5 -> 1.2.6
minimist 0.0.10 -> 0.2.4

GitHub Vulnerability Alerts

CVE-2020-7598

Affected versions of minimist are vulnerable to prototype pollution. Arguments are not properly sanitized, allowing an attacker to modify the prototype of Object, causing the addition or modification of an existing property that will exist on all objects.
Parsing the argument --__proto__.y=Polluted adds a y property with value Polluted to all objects. The argument --__proto__=Polluted raises and uncaught error and crashes the application.
This is exploitable if attackers have control over the arguments being passed to minimist.

Recommendation

Upgrade to versions 0.2.1, 1.2.3 or later.

CVE-2021-44906

Minimist prior to 1.2.6 and 0.2.4 is vulnerable to Prototype Pollution via file index.js, function setKey() (lines 69-95).


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests here seem to fall exactly as we would hope with their expected failure rate.

Additionally, this PR does not seem to actually change any behavior of the editor or it's core packages. All changes here effect only the package-lock.json meaning the newest rolling releases of the editor likely already ship with these fixes.

And as it's a security fix I see no reason why we shouldn't merge this one, so LGTM

@confused-Techie
Copy link
Member

As I said previously, this PR changes essentially nothing for functionality, only bumping versions of packages that are likely already bumped. So I'll go ahead and merge this one

@confused-Techie confused-Techie merged commit a030615 into master Apr 29, 2023
@confused-Techie confused-Techie deleted the renovate/npm-minimist-vulnerability branch April 29, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant