Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency ajv to 6.12.3 [security] #501

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 18, 2023

Mend Renovate

This PR contains the following updates:

Package Change
ajv 5.5.2 -> 6.12.3
ajv 4.11.8 -> 6.12.3

GitHub Vulnerability Alerts

CVE-2020-15366

An issue was discovered in ajv.validate() in Ajv (aka Another JSON Schema Validator) 6.12.2. A carefully crafted JSON schema could be provided that allows execution of other code by prototype pollution. (While untrusted schemas are recommended against, the worst case of an untrusted schema should be a denial of service, not execution of code.)


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/npm-ajv-vulnerability branch from b087d2d to fd68d66 Compare April 19, 2023 01:47
Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests are failing exactly how we would expect, most importantly in autocomplete-plus.

Both in dalek and settings-view this just changes the package-lock.json meaning the most recent builds of Pulsar likely already come with this version.

Whereas autocomplete-plus has the only package.json change. But all tests are passing there exactly as we'd expect, so unless anyone has any concerns we should absolutely merge this to resolve the security vulnerability.

@renovate renovate bot force-pushed the renovate/npm-ajv-vulnerability branch from fd68d66 to e8547e5 Compare April 27, 2023 13:22
@confused-Techie
Copy link
Member

With all tests passing, and the impact of this dep bump seemingly being very low, I'll go ahead and merge this one, as it is a security issue. But as always we can keep an eye on any issues that may arise.

@confused-Techie confused-Techie merged commit 1bf6303 into master Apr 27, 2023
@confused-Techie confused-Techie deleted the renovate/npm-ajv-vulnerability branch April 27, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant