-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update resources metadata #414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure electron-builder
is not wired up to use any of these files at the moment.
But macOS doesn't use dev.pulsar_edit.Pulsar
, it uses dev.pulsar-edit.pulsar
.
Co-authored-by: confused_techie <[email protected]>
Co-authored-by: DeeDeeG <[email protected]>
Co-authored-by: DeeDeeG <[email protected]>
Co-authored-by: DeeDeeG <[email protected]>
Indeed, as far as I'm aware it doesn't. I do wonder if we can have it use these files, however, just to give us some static control over what it generates. I also committed all the suggestions, thanks @confused-Techie @DeeDeeG ! I may switch this back to a draft shortly, as I think I need to do some additional work and this isn't quite as close to merging as I had originally planned (undecided yet, however) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, because:
Basically these improvements are accurate to the rebranding efforts, and it wouldn't hurt for these to be accurate if we're keeping these files around, even if we're not using them at the moment.
The pulsar.sh change seems like it could be helpful right away, though I haven't thought through exactly when it comes into play, I'd speculate it'd be for opening Pulsar from the CLI on macOS.
(One-character change requested just above.)
Co-authored-by: Daeraxa <[email protected]>
Co-authored-by: DeeDeeG <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna leave another approve here, since adding these changes could help the conversation we had on Discord, about getting GitHub Desktop to find Pulsar.
But I do want to mention real quick, when initially reviewing this PR I missed this. But the .plist
files for MacOS (I don't think) are being used anywhere at all anymore.
The data for the helper-Info.plist
is being generated in the electron-builder
file. So if we want the CFBundleIdentifier
to be specified it should be added there. But I believe it is being added automatically.
Otherwise this PR looks fantastic, and lets get it merged!
xprop WM_CLASS
, click on pulsar)This brings several metadata files in-line with what they should be, although
electron-builder
isn't currently using them. This also makes the primary method for launching the application withinpulsar.sh
work correctly since the ID is now correct.