Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resources metadata #414

Merged
merged 12 commits into from
Mar 24, 2023
Merged

Update resources metadata #414

merged 12 commits into from
Mar 24, 2023

Conversation

Spiker985
Copy link
Member

@Spiker985 Spiker985 commented Mar 4, 2023

  • Set Debian maintainer to match package.json author (File unused atm)
  • Update WMClass to match actual window WMClass (start pulsar, open terminal xprop WM_CLASS, click on pulsar)
  • Update policy to use pulsar id (File unused atm)
  • Update RedHat spec to use proper URL (File unused atm)
  • Update RedHat spec to use proper location for ppm (File unused atm)
  • Add --no-sandbox to .desktop entry template (File unused atm)

This brings several metadata files in-line with what they should be, although electron-builder isn't currently using them. This also makes the primary method for launching the application within pulsar.sh work correctly since the ID is now correct.

Copy link
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure electron-builder is not wired up to use any of these files at the moment.

But macOS doesn't use dev.pulsar_edit.Pulsar, it uses dev.pulsar-edit.pulsar.

@Spiker985
Copy link
Member Author

Pretty sure electron-builder is not wired up to use any of these files at the moment.

But macOS doesn't use dev.pulsar_edit.Pulsar, it uses dev.pulsar-edit.pulsar.

Indeed, as far as I'm aware it doesn't. I do wonder if we can have it use these files, however, just to give us some static control over what it generates.

I also committed all the suggestions, thanks @confused-Techie @DeeDeeG !

I may switch this back to a draft shortly, as I think I need to do some additional work and this isn't quite as close to merging as I had originally planned (undecided yet, however)

Copy link
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, because:

Basically these improvements are accurate to the rebranding efforts, and it wouldn't hurt for these to be accurate if we're keeping these files around, even if we're not using them at the moment.

The pulsar.sh change seems like it could be helpful right away, though I haven't thought through exactly when it comes into play, I'd speculate it'd be for opening Pulsar from the CLI on macOS.

(One-character change requested just above.)

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna leave another approve here, since adding these changes could help the conversation we had on Discord, about getting GitHub Desktop to find Pulsar.

But I do want to mention real quick, when initially reviewing this PR I missed this. But the .plist files for MacOS (I don't think) are being used anywhere at all anymore.

The data for the helper-Info.plist is being generated in the electron-builder file. So if we want the CFBundleIdentifier to be specified it should be added there. But I believe it is being added automatically.

Otherwise this PR looks fantastic, and lets get it merged!

@mauricioszabo mauricioszabo merged commit 03eace7 into master Mar 24, 2023
@mauricioszabo mauricioszabo deleted the s985-debian-maintainer branch March 24, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants