json language - add .har extension #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
confused-Techie
approved these changes
Feb 24, 2023
There was a problem hiding this comment.
This change looks great to me!
Also a total side note, we may want to revise the file extensions we support on macOS to include har as well in our ./script/mac-bundle-document-types.js. (This is not at all expected of this PR just a note to myself for later or anyone else that wants to do so.)
But yeah this only makes sense to add
But as always thanks for contributing!
DeeDeeG
approved these changes
Feb 25, 2023
There was a problem hiding this comment.
Looks good to me!
Thanks for the contribution!
Context:
The HTTP Archive format, or HAR, is a JSON-formatted archive file[1] format for logging of a web browser's interaction with a site. The common extension for these files is .har.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Add .har format extension to language-json library