Add new macOS icon

[mdibella-dev]

This pull request replaces the faulty app icon (beta.png) - currently only used in macOS, see issue #364 - with a new app icon (beta.icns).

The new icon corresponds to Apple's Human Interface Guidlines.

[Daeraxa]

The current icon is still pretty much a placeholder and we haven't decided if we want to use the squircle or a unified app icon yet. Was it made from the svg or the png?

[mdibella-dev]

Currently from the PNG

[confused-Techie]

So while this looks awesome, and is something that should be talked about if we wanted to move to this style of icon, like mentioned above our icons aren't finalized, and that's largly why we haven't done this ourselves.

Although it is recommended to make the icon from an SVG just to get the most quality, and while I love the effort you've put here, I do want to mention that we have a PR that adds all of the Pulsar Iconography to our .github repo on this PR.

Of which, within this PR we do have the following icons that have already been made by the community to serve as MacOS Icon:

Now I don't mean to discount the work you've already done, and it's very much appreciated, but this does already exist, and was made from the original SVG.

[confused-Techie]

Although I do want to add that having a proper ICNS icon is quite a nice thing.

I know we are wanting to vote on the flavour of apple icons to use, but maybe if we could update the icon you're using in the icns with the one I provided above, (That way we still get proper scaling and support on Apple's side) then we can vote on the icon and merge this one to resolve the issue?

Then if push comes to shove and the designer gets back with finalized icons, we can still replace everything

[mdibella-dev]

Although I do want to add that having a proper ICNS icon is quite a nice thing.

I know we are wanting to vote on the flavour of apple icons to use, but maybe if we could update the icon you're using in the icns with the one I provided above, (That way we still get proper scaling and support on Apple's side) then we can vote on the icon and merge this one to resolve the issue?

Then if push comes to shove and the designer gets back with finalized icons, we can still replace everything

Made a new one with the icon you have supplied.

[confused-Techie]

After bringing this up on Discord it doesn't seem anyone on the team feels strongly about requiring a poll for this decision, and those that were MacOS users did seem to think this would be a good direction to go with our iconography on that platform.

Now especially since we are properly using our first party icons here, I'll go ahead and approve this one. To me it looks great, with the proper steps taken in electron-builder as well.

Otherwise anyone else from @pulsar-edit/core @pulsar-edit/documentation can feel free to chime in as well.

But to me looks good and lets get it merged!

[meadowsys]

The smallest icon XD

Looked through the icns file (from Preview on macOS) and the code, I think everything looks okay.

edit; manually set it as my app icon, aaa it looks good, I like it c:

[aphive]

The current icon is still pretty much a placeholder and we haven't decided if we want to use the squircle or a unified app icon yet. Was it made from the svg or the png?

Hope the PR gets approved, I think the square fits perfectly with all other Mac icons... Looks great on my Linux machine running Pop! OS too.

[confused-Techie]

Considering we currently have two approvals, and the issue brought up previously has now been addressed, I'll go ahead and merge this one!

Glad to see everyone working together on this issue!