Uncomment and fix a settings-view package test #366
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick follow-up to #307.
What this fix is all about (click to expand):
There is a special handling of internal/bundled packages which specify their
repository
field ofpackage.json
as the exact GitHub repo URL of the main editor...The editor (specifically some logic in the
settings-view
package, I guess) understands that bundled packages with"repository": "https://github.com/pulsar-edit/pulsar"
should link to this repo'spackages/[package name here]
subdir, not just to the root repo URL as specified verbatim in the package's package.json, i.e.https://github.com/pulsar-edit/pulsar
This updates the dummy spec package used for this spec to have its
repository
URL behttps://github.com/pulsar-edit/pulsar
instead of the oldhttps://github.com/atom/atom
. Which, after this change, then matches with the editor's ownrepository
URL in its own package.json. So the test, which assumes the special handling described above is in play, works as intended again and passes.So this fixes a test that been failing and which got commented out during #307. (The fix is essentially a tiny re-branding task.)
This gives us one more test running, one more test passing. Not a huge deal, but feels better than just commenting this one out, and I got the fix sorted relatively quickly, so here we are. Figured I may as well submit this as a PR.