Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While originally this PR set out to create a new package test runner script, I've ditched the idea as listing each core package as it's own test in unwieldy and overall more difficult to manage.
So instead I've gone ahead and just resolved our caching issues.
Previously our
ppm
andnode_modules
cache used a hash of the file, but the inside of a package can change with no change to the file itself, leaving old caches being used on package tests which would mean changes to packages were not present in the test, which could lead to false positives, and false negatives on error status.So instead the cache now uses the Commit SHA for it's name. Meaning the cache can still be used per commit, providing some speed advantage, but will now accurately reflect the changes within each package.