Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix install on packaged code #269

Merged
merged 2 commits into from
Dec 28, 2022
Merged

Fix install on packaged code #269

merged 2 commits into from
Dec 28, 2022

Conversation

mauricioszabo
Copy link
Contributor

When we generate a binary with electron-builder or other tool, the argument parser gets weird and we lose the ability to detect that, after install <git-package> we have a -t that needs to be sent to ppm, etc.

This PR fixes this.

confused-Techie
confused-Techie approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While not in a position to test, the changes here look solid, and if they fix issues we are seeing in production lets merge it

@confused-Techie confused-Techie mentioned this pull request Dec 28, 2022
Merged
@mauricioszabo mauricioszabo merged commit 77234cd into master Dec 28, 2022
@mauricioszabo mauricioszabo deleted the fix-install-on-packaged-code branch December 28, 2022 01:09
@DeeDeeG DeeDeeG mentioned this pull request Dec 28, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@confused-Techie confused-Techie confused-Techie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mauricioszabo @confused-Techie