[fix] Postinstall error with rm /usr/bin/pulsar #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this is a shell (sh) file and not a bash file, rather than doing a `if [[ -f "" ]]` condition, we can just throw away the error if it doesn't exist A whole lot safer than using `-f/--force`
DeeDeeG
reviewed
Dec 16, 2022
|
Yeah, I bounced back and forth. I'm not necessarily sure if the postinstall has to continue to be a sh file over a bash file, but there's definitely a way to do the same IF check within sh if we wanted Actually, you've made me rethink this. I think I'm actually going to switch it over to the IF statement, because if the current user (for whatever reason) doesn't have access to delete that file, the redirection would chuck that error to the void |
On second thought, throwing all errors to the void would also throw permission issues to the void as well. So we'll just test for the file existence and echo a message if it isn't found
|
Man, that is quite annoying, renaming a branch which already has a PR, doesn't simply renamed the branch the PR is targeting - nah it deletes the whole thing |
DeeDeeG
reviewed
Dec 17, 2022
We'll just remove the else statement for now, and if people report issues later, we can simply recreate it Co-authored-by: DeeDeeG <[email protected]>
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redirect stderr to /dev/null
Since this is a shell (sh) file and not a bash file, rather than doing an
if [[ -f "" ]]condition, we can just throw away the error if it doesn't existA whole lot safer than using
-f/--forceShould fix #215