Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add or update packages/*/package-lock.json #209

Conversation

sertonix
Copy link
Contributor

This updates or adds the packages/*/package-lock.json files.
This is to achieve consistent builds even if single packages are build. And also is a lot more consistent than before.

@AstroPrime1
Copy link
Contributor

Ok cool hopefully this will help me run it using yarn

@sertonix
Copy link
Contributor Author

Ok cool hopefully this will help me run it using yarn

I don't think this will help, sorry. This should not effect the main build.

@confused-Techie
Copy link
Member

So on this, I'm not sure this will have the effect intended. The main editor should always be built with using yarn which will be ignored in this instance. The bundled packages would then also be built with yarn when the editor is built.

I may recommend that if you wanted to improve the consistency of builds for our bundled packages would be instead to remove all the npm lock files and replace with yarn but even then, I'm not sure if that has an effect or if those deps are then hoisted to the main editor lock file. Which the latter is what I believe is happening

@sertonix
Copy link
Contributor Author

Since ppm is using npm internally these lock files would be used if these packages are installed directly. So I would say a npm lock file makes more sense.

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As confirmed on our Discord, included these may make builds easier in an edge case, but valid usage non-the-less.

Specifically if a user where to install one of our bundled packages using ppm when pointing at a local copy, then these lock files could be of assistance. Since ppm uses npm for installation.

Otherwise when building the editor, they will just be ignored, and we can ensure that we write additional exclusions for these files.

But in that case this looks great to me, and would be fine with merging.

confused-Techie added a commit that referenced this pull request Dec 10, 2022
confused-Techie added a commit that referenced this pull request Dec 12, 2022
@confused-Techie confused-Techie merged commit 2eab519 into pulsar-edit:master Dec 14, 2022
@sertonix sertonix deleted the add-or-update-packages-package-lock.js branch December 14, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants