ppm: Update ppm submodule (new Electron headers download URL) #198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Adding, Changing, or Removing a Feature (from template, click to expand:
Issue or RFC
Endorsed by Atom's Maintainerspulsar-edit/ppm#43
Description of the Change
This syncs Pulsar's
ppm
submodule to the latest commits from https://github.com/pulsar-edit/ppmmaster
branch.Particularly: This includes the updated Electron headers download URL.
Alternate Designs
None
Possible Drawbacks
None. The old endpoint (headers download bucket) was deprecated, this is the new official one. It has only stronger guarantees of reliability than the old one.
If this new URL goes down, it means the whole Electron ecosystem is just as affected as we are. If the old URL independently went down, it would mean we (Atom and all of its forks) were uniquely affected. Although that has never happened to my knowledge, with the deprecation it is quite likely to permanently go down some time in the future, which could easily happen as early as December 15th, as per the updated Sunset Announcement.
Verification Process
First, verified the fix in terms of just the
ppm
repo -- see testing notes over at pulsar-edit/ppm#43 (comment).Then, tested this update in Pulsar as well, locally on Linux, with the
.deb
package of Pulsar from this branch, using the following command:/opt/Pulsar/resources/app/ppm/bin/apm install language-carp --verbose
You can see the following relevant output (irrelevant stuff snipped for length) (click to expand):
Release Notes
Updated to the new Electron headers download URL in ppm (old URL is deprecated)