Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppm: Update ppm submodule (new Electron headers download URL) #198

Merged

Conversation

DeeDeeG
Copy link
Member

@DeeDeeG DeeDeeG commented Dec 5, 2022

Requirements for Adding, Changing, or Removing a Feature (from template, click to expand:

Issue or RFC Endorsed by Atom's Maintainers

pulsar-edit/ppm#43

Description of the Change

This syncs Pulsar's ppm submodule to the latest commits from https://github.com/pulsar-edit/ppm master branch.

Particularly: This includes the updated Electron headers download URL.

Alternate Designs

None

Possible Drawbacks

None. The old endpoint (headers download bucket) was deprecated, this is the new official one. It has only stronger guarantees of reliability than the old one.

If this new URL goes down, it means the whole Electron ecosystem is just as affected as we are. If the old URL independently went down, it would mean we (Atom and all of its forks) were uniquely affected. Although that has never happened to my knowledge, with the deprecation it is quite likely to permanently go down some time in the future, which could easily happen as early as December 15th, as per the updated Sunset Announcement.

Verification Process

First, verified the fix in terms of just the ppm repo -- see testing notes over at pulsar-edit/ppm#43 (comment).

Then, tested this update in Pulsar as well, locally on Linux, with the .deb package of Pulsar from this branch, using the following command:

/opt/Pulsar/resources/app/ppm/bin/apm install language-carp --verbose

You can see the following relevant output (irrelevant stuff snipped for length) (click to expand):
[ . . . ]
gyp verb command install [ '12.2.3' ]
gyp verb download using dist-url https://artifacts.electronjs.org/headers/dist
[ . . . ]
gyp verb install version not already installed, continuing with install 12.2.3
[ . . . ]
gyp http GET https://artifacts.electronjs.org/headers/dist/v12.2.3/node-v12.2.3-headers.tar.gz
REQUEST {
  uri: 'https://artifacts.electronjs.org/headers/dist/v12.2.3/node-v12.2.3-headers.tar.gz',
  headers: {
    'User-Agent': 'node-gyp v5.1.0 (node v16.0.0)',
    Connection: 'keep-alive'
  },
  callback: undefined
}
REQUEST make request https://artifacts.electronjs.org/headers/dist/v12.2.3/node-v12.2.3-headers.tar.gz
REQUEST onRequestResponse https://artifacts.electronjs.org/headers/dist/v12.2.3/node-v12.2.3-headers.tar.gz 200 {
  'content-length': '249949',
  'content-type': 'application/octet-stream',
  'content-md5': 'D+DaGl6ms34YKPjPlGvbTw==',
  'last-modified': 'Fri, 01 Apr 2022 02:15:21 GMT',
  etag: '0x8DA1385798B3860',
  server: 'Windows-Azure-Blob/1.0 Microsoft-HTTPAPI/2.0',
  'x-cache': 'TCP_REMOTE_HIT',
  'x-ms-request-id': '308b45b0-a01e-0000-1528-08df6f000000',
  'x-ms-version': '2009-09-19',
  'x-ms-lease-status': 'unlocked',
  'x-ms-blob-type': 'BlockBlob',
  'x-azure-ref-originshield': '06kOOYwAAAABzpzDFVYq+QKE9liZ86GxwTU5aMjIxMDYwNjEyMDM5ADBkYTBhZjUzLTkxMmUtNDU0My05Y2Q3LTU5YTIxY2I2NWYzMQ==',
  'x-azure-ref': '06kOOYwAAAAANIfEMGe9aQb6Sih82DX5oTU5aMjIxMDYwNjE0MDExADBkYTBhZjUzLTkxMmUtNDU0My05Y2Q3LTU5YTIxY2I2NWYzMQ==',
  date: 'Mon, 05 Dec 2022 19:18:02 GMT'
}
gyp http 200 https://artifacts.electronjs.org/headers/dist/v12.2.3/node-v12.2.3-headers.tar.gz
REQUEST finish init function https://artifacts.electronjs.org/headers/dist/v12.2.3/node-v12.2.3-headers.tar.gz
[ . . . ]
gyp verb check download content checksum, need to download `SHASUMS256.txt`... 
gyp verb checksum url https://artifacts.electronjs.org/headers/dist/v12.2.3/SHASUMS256.txt
gyp http GET https://artifacts.electronjs.org/headers/dist/v12.2.3/SHASUMS256.txt
REQUEST {
  uri: 'https://artifacts.electronjs.org/headers/dist/v12.2.3/SHASUMS256.txt',
  headers: {
    'User-Agent': 'node-gyp v5.1.0 (node v16.0.0)',
    Connection: 'keep-alive'
  },
  callback: undefined
}
REQUEST make request https://artifacts.electronjs.org/headers/dist/v12.2.3/SHASUMS256.txt
REQUEST onRequestResponse https://artifacts.electronjs.org/headers/dist/v12.2.3/SHASUMS256.txt 200 {
  'content-length': '1097',
  'content-type': 'application/octet-stream',
  'content-md5': 'y+TB8csfY2P8le4xkVW6zw==',
  'last-modified': 'Fri, 01 Apr 2022 02:15:28 GMT',
  etag: '0x8DA13857D4B35DE',
  'x-cache': 'TCP_MISS',
  server: 'Windows-Azure-Blob/1.0 Microsoft-HTTPAPI/2.0',
  'x-ms-request-id': '2a9372f3-001e-0044-63de-085550000000',
  'x-ms-version': '2009-09-19',
  'x-ms-lease-status': 'unlocked',
  'x-ms-blob-type': 'BlockBlob',
  'x-azure-ref': '06kOOYwAAAABMA5hWlIyjS5zEfLK0/4//TU5aMjIxMDYwNjExMDQ1ADBkYTBhZjUzLTkxMmUtNDU0My05Y2Q3LTU5YTIxY2I2NWYzMQ==',
  date: 'Mon, 05 Dec 2022 19:18:02 GMT'
}
gyp http 200 https://artifacts.electronjs.org/headers/dist/v12.2.3/SHASUMS256.txt
REQUEST finish init function https://artifacts.electronjs.org/headers/dist/v12.2.3/SHASUMS256.txt
REQUEST response end https://artifacts.electronjs.org/headers/dist/v12.2.3/SHASUMS256.txt 200 {
  'content-length': '1097',
  'content-type': 'application/octet-stream',
  'content-md5': 'y+TB8csfY2P8le4xkVW6zw==',
  'last-modified': 'Fri, 01 Apr 2022 02:15:28 GMT',
  etag: '0x8DA13857D4B35DE',
  'x-cache': 'TCP_MISS',
  server: 'Windows-Azure-Blob/1.0 Microsoft-HTTPAPI/2.0',
  'x-ms-request-id': '2a9372f3-001e-0044-63de-085550000000',
  'x-ms-version': '2009-09-19',
  'x-ms-lease-status': 'unlocked',
  'x-ms-blob-type': 'BlockBlob',
  'x-azure-ref': '06kOOYwAAAABMA5hWlIyjS5zEfLK0/4//TU5aMjIxMDYwNjExMDQ1ADBkYTBhZjUzLTkxMmUtNDU0My05Y2Q3LTU5YTIxY2I2NWYzMQ==',
  date: 'Mon, 05 Dec 2022 19:18:02 GMT'
}
[ . . . ]

Release Notes

Updated to the new Electron headers download URL in ppm (old URL is deprecated)

Includes updated Electron headers download URL.
(See: pulsar-edit/ppm#43)
@DeeDeeG DeeDeeG requested a review from a team December 5, 2022 19:40
@DeeDeeG DeeDeeG merged commit 2063bf3 into master Dec 5, 2022
@DeeDeeG
Copy link
Member Author

DeeDeeG commented Dec 5, 2022

Thanks for the approval! Merged.

@DeeDeeG DeeDeeG deleted the update-ppm-submodule-for-electron-header-download-URL-update branch December 5, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants