-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump GitHub package #186
Bump GitHub package #186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me and is an important update. Love seeing the ChangeLog being updated,
But otherwise do we have to keep the 0.36.12-fix
? Looks like a regular tag was also generated on github
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope that this new version improves things, which it seems that it is at least slightly. Just gotta keep the rest of it up to date with these new changes, then I say lets merge
Is anything blocking this pr in particular? |
So this PR is essentially valid, but due to having to technically bump twice over the course of this PR, some of the other details are inaccurate as you can see in my review comments. Suppose we haven't gotten around to fixing those yet, but I may just commit my comments myself, and take a look at the tests how things are going. I think the PR lost some steam since it didn't totally fix the issues we saw, but still wouldn't be bad to at least include another bump in here |
What does it not fix? As far as I remember the only reason for the bump was to get to a version that supports apple silicon. |
Performance Issues mainly, but yeah fair enough it does tackle the main reason it was created. I'll go ahead and apply the reviews manually, and merge this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests here look good, and like previously stated this adds support for Apple Silicon, I'll go ahead and merge
No description provided.