Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup/standardize pulsar.sh #175

Merged
merged 4 commits into from
Nov 25, 2022

Conversation

Spiker985
Copy link
Member

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I can't test these changes, it looks good here, and there's no obvious failures on the test, but I don't believe the tests are checking this file at all to be honest.

But it looks good, and has clear and understandable code, so I'd say lets merge this one.

Although I did add a quality of life suggestion, which isn't required for a merge, but thought it to be helpful

Co-authored-by: confused_techie <[email protected]>
@confused-Techie
Copy link
Member

Thanks for adding the changes requested, if this looks fine to everyone in @pulsar-edit/core then I'll go ahead and merge in a little bit here

@confused-Techie confused-Techie merged commit 6d29a5e into pulsar-edit:master Nov 25, 2022
@Spiker985 Spiker985 deleted the update-pulsar-sh branch November 26, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants