removed fs-plus from exception-reporting pack
#118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
confused-Techie
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
This looks great to me! The relevant tests are passing at the expected rate of 82 Failures, so nothing new is broken.
One interesting note is the testing for (welcome, about, background-tips...) which has an expected failure rate of 178 failures, only had 165 failures on this run. May be some weirdness there, or in some places they interact with this? Not sure but regardless this looks good.
Thanks for the contribution!
|
Feel this PR has been up for an acceptable amount of days without further interaction. As tests that are effected are looking good I'll go ahead and merge this one. Thanks again for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
fs-plusdependencie from the exception-reporting package.