Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use init.js by default #112

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Conversation

sertonix
Copy link
Contributor

@sertonix sertonix commented Nov 3, 2022

This replaces the default init.coffee with an init.js. Both are still handled just the default is moved to match the new direction of pulsar.

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me. The only thing I might recommend is making the same PR changes on CONTRIBUTING.md to .github/CONTRIBUTING.md since that is the version we will likely keep in the long run.

Otherwise looks great, and I appreciate you keeping the docs up to date during your PR's as well.

@mauricioszabo
Copy link
Contributor

This is actually pretty good, I've been using the init.js for a while, never saw that Atom didn't change the default init script from Coffee. Merging it now :)

@mauricioszabo mauricioszabo merged commit e45b16c into pulsar-edit:master Nov 10, 2022
@Daeraxa
Copy link
Member

Daeraxa commented Nov 10, 2022

We will also need to update the docs (once the CH2 PR is merged) to reflect this because it currently references the init.coffee in a bunch of places along with code examples.

CH3 is yet to be added (hacking-pulsar) as this has a more in-depth section on it: see the archived version here - https://pulsar-edit.dev/docs/atom-archive/hacking-atom/#the-init-file

Also if the plan is eventually to have an "atom->pulsar" automatic onboarding, a feature to automatically migrate from the .coffee file to the .js one would be rather handy.

@mauricioszabo
Copy link
Contributor

@Daeraxa can we document somewhere, maybe on some discussion, the steps we feel are needed for this atom->pulsar automatic onboarding to work?

@Daeraxa
Copy link
Member

Daeraxa commented Nov 10, 2022

Sure, I'll make GH thread for it so we can keep track of it then maybe convert it to a project once we have an idea.
Edit - https://github.com/orgs/pulsar-edit/discussions/63

@sertonix sertonix deleted the init-js branch November 13, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants