Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all references to atom or atom community #11

Merged
merged 2 commits into from Aug 18, 2022
Merged

remove all references to atom or atom community #11

merged 2 commits into from Aug 18, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 7, 2022

In README at least.

@ghost ghost mentioned this pull request Aug 7, 2022
Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, I've added one change I think we should fix while here, but otherwise appreciate the contribution!

@ghost ghost requested review from confused-Techie and meadowsys August 7, 2022 21:43
Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the changes! But this looks great to me, while its on Pulsar, since its the readme I'll ping our @pulsar-edit/documentation team to get some additional feedback on what they think. Super rad work!

Copy link
Member

@meadowsys meadowsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, the logo guidelines will need to be updated/removed (since we are not GitHub), and CI will need to be updated once we have working CI again (as per #12), but otherwise I think it looks good!

@ghost
Copy link
Author

ghost commented Aug 8, 2022

the logo guidelines will need to be updated/removed (since we are not GitHub)

requires: a new logo.

@meadowsys
Copy link
Member

hehe, I think progress is actually being made on that c:

@confused-Techie
Copy link
Member

So how do we feel about merging this one as is, then once builds are sorted we could modify as needed, and hopefully once the artist being worked with is sorted (or alternative method) we could update that. Since really I'm happy with incremental changes even if we miss a couple things, as long as we know about them

@ghost
Copy link
Author

ghost commented Aug 9, 2022

So how do we feel about merging this one as is, then once builds are sorted we could modify as needed, and hopefully once the artist being worked with is sorted (or alternative method) we could update that. Since really I'm happy with incremental changes even if we miss a couple things, as long as we know about them

Ok.

@mauricioszabo mauricioszabo merged commit 6e24438 into pulsar-edit:master Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants