Add options for [skip-ci], [skip-editor-ci], and [skip-package-ci] on PR #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow skipping tests when not required, for example, when only making changes to MD files.
Allow skipping tests when not required, for example, when only making changes to MD files.
Allow for one set of tests to be skipped, while still testing the other
Allow for one set of tests to be skipped, while still testing the other
- Updated job names to better align the actions being performed during them
- Format step names
confused-Techie
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
This looks great to me. And also love that this can cut down on the many tests that are created for every single PR. And lets us be a little nicer to GitHub's servers.
The only thing I'd recommend is, either adding it to this PR, or additionally opening a PR on our website, or really somewhere to add the documentation about this.
Maybe we even just add it to the PR template?
|
@confused-Techie Added PR pulsar-edit/.github#54 to coincide |
|
@pulsar-edit/core Can we have someone else review this PR? |
mauricioszabo
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow skipping tests when not required, for example, when only making changes to MD files.
The conditions are only set up to skip during the
pull_requestevent. What that means in practice, is that the workflows will still execute when you merge a PR, regardless of whether the title starts with one of the 3 options above