Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some quality issues with our
ico
file on Windows.Really I've just gone ahead and manually scaled down the icon to the below values.
I've now done a second iteration of the icon. I read through Microsoft's documentation to try and determine what sizes may actually be used, further I took the
.ico
file of a few different applications ranging in popularity to try and determine what we may want to support.If you'd like to view that research, feel free to expand this section.
In the end I took a rather generous approach in support, while getting rid of the sizes that wouldn't be used by Windows.
In the rest of the PR text the
v1
information relates to my first attempt at the icon. Whilev2
refers to the latest attempt, this is the one that would be merged if this PR is approved. While of courseOld
refers to the currently in use icon.Although the difference in icon quality may not be obvious between
v1
andv2
because the icon itself is actually about72%
smaller in size, it seems obvious to prefer that one, if there's no obvious dip in quality. Although I've left the images of my first attempt, in case we do determine that one looks the best.Icon File Size
26.3KB
239KB
171KB
Icon Sizes
New Icon v1
16x16
32x32
48x48
256x256
512x512
1024x1024
New Icon v2
16x16
24x24
32x32
48x48
64x64
96x96
128x128
256x256
Old
256x256
This was all done with our "hero" Pulsar image used for other platforms. But while this icon still falls short in some instances, I feel it does provide a general slight improvement across the board. If we really wanted some amazing results we would have to get a designer back to take a look at the icon at such small sizes, but I talk more about that on Discord if it is something we want to pursue.
If we would like, I'd be more than happy to include the Gimp project file used to create this image in the repo, or we can place it elsewhere like the
.github
repo.Fixes #1064
Examples
App Icon
New v2
New v1
Old
Context Menu
New v2
New v1
Old
Desktop
New v2
New v1
Old
File Explorer
New v2
New v1
Old
Installer
New v2
New v1
Old
Search
New v2
New v1
Old
Start Menu
New v2
New v1
Old
Taskbar
New v2
New v1
Old