Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] Improve Icon #1072

Merged
merged 2 commits into from
Aug 7, 2024
Merged

[windows] Improve Icon #1072

merged 2 commits into from
Aug 7, 2024

Conversation

confused-Techie
Copy link
Member

@confused-Techie confused-Techie commented Jul 31, 2024

This PR addresses some quality issues with our ico file on Windows.

Really I've just gone ahead and manually scaled down the icon to the below values.

I've now done a second iteration of the icon. I read through Microsoft's documentation to try and determine what sizes may actually be used, further I took the .ico file of a few different applications ranging in popularity to try and determine what we may want to support.

If you'd like to view that research, feel free to expand this section.

table

In the end I took a rather generous approach in support, while getting rid of the sizes that wouldn't be used by Windows.

In the rest of the PR text the v1 information relates to my first attempt at the icon. While v2 refers to the latest attempt, this is the one that would be merged if this PR is approved. While of course Old refers to the currently in use icon.

Although the difference in icon quality may not be obvious between v1 and v2 because the icon itself is actually about 72% smaller in size, it seems obvious to prefer that one, if there's no obvious dip in quality. Although I've left the images of my first attempt, in case we do determine that one looks the best.

Icon File Size

  • Old Icon: 26.3KB
  • New Icon v1: 239KB
  • New Icon v2: 171KB

Icon Sizes

New Icon v1

  • 16x16
  • 32x32
  • 48x48
  • 256x256
  • 512x512
  • 1024x1024

New Icon v2

  • 16x16
  • 24x24
  • 32x32
  • 48x48
  • 64x64
  • 96x96
  • 128x128
  • 256x256

Old

  • 256x256

This was all done with our "hero" Pulsar image used for other platforms. But while this icon still falls short in some instances, I feel it does provide a general slight improvement across the board. If we really wanted some amazing results we would have to get a designer back to take a look at the icon at such small sizes, but I talk more about that on Discord if it is something we want to pursue.

If we would like, I'd be more than happy to include the Gimp project file used to create this image in the repo, or we can place it elsewhere like the .github repo.

Fixes #1064


Examples

App Icon

New v2

app-icon

New v1

app-icon

Old

app-icon

Context Menu

New v2

context-menu

New v1

context-menu

Old

context-menu

Desktop

New v2

desktop

New v1

desktop

Old

desktop

File Explorer

New v2

file-explorer

New v1

file-explorer

Old

file-explorer

Installer

New v2

installer

New v1

installer

Old

installer

Search

New v2

search

New v1

search

Old

search

Start Menu

New v2

start-menu

New v1

start-menu

Old

start-menu

Taskbar

New v2

taskbar

New v1

taskbar

Old

taskbar

@savetheclocktower
Copy link
Contributor

New and old start menu look identical to me… but otherwise this is a vast improvement.

Doesn't rule out other improvements in the future if we broaden our visual identity, but this is 👍 from me.

@confused-Techie
Copy link
Member Author

Thanks for providing an approval on this one! I'll go ahead and merge it

@confused-Techie confused-Techie merged commit 5d0e836 into master Aug 7, 2024
103 checks passed
@confused-Techie confused-Techie deleted the win-icon-improvement branch August 7, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Pulsar icon on Windows is low-quality
2 participants