Testing superstring in CI, 3rd edition #1049
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…git repo URL Just controlling some variables...
|
Closing this "test" PR. See #1051 for the solution that was eventually arrived at. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a test...
Basically this is branched from #1048, but reverting to the same SHA of
superstringas we are using onmaster, just delivered in a different way frommaster. Delivered as a git repo URL (which behaves differently, a local clone into a temp dir + cd there andyarn install(with devDependencies and all, potentially running different lifecycle scripts) then copy the result out tonode_modules, vs fetching a tarball, extracting intonode_modulesand installing in-situ.)See the commit message of this commit: 02e2908