Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cirrus: Fix gem install fpm on ARM Linux #1008

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

DeeDeeG
Copy link
Member

@DeeDeeG DeeDeeG commented May 16, 2024

Issue

Arm Linux CI builds are failing on Cirrus. See this failing CI run: https://cirrus-ci.com/task/6219208260845568?logs=prepare#L2634-L2639

Issue Details

From the error message :
mkmf.rb can't find header files for ruby at /usr/lib/ruby/include/ruby.h

And from this StackOverflow answer: https://stackoverflow.com/questions/20559255/error-while-installing-json-gem-mkmf-rb-cant-find-header-files-for-ruby

I think we just need to install ruby-dev package in the Debian container.

Solution

Apparently we need ruby-dev (development headers) package to build fpm gem's native extensions now?!

Well, it's an easy fix. Not sure why we didn't need this up until now, but oh, well.

Verification process

Test run in Cirrus: https://cirrus-ci.com/task/5547408132669440

Re-run of the test run in Cirrus: https://cirrus-ci.com/task/4548855918755840

Apparently we need `ruby-dev` (development headers) package
to build fpm gem's native extensions now?!

Well, it's an easy fix. Not sure why we didn't need this up until now,
but oh, well.
Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the run succeeds as far as it needs to (until it was manually canceled by you) this looks great to me! Awesome work on the quick find

@DeeDeeG
Copy link
Member Author

DeeDeeG commented May 16, 2024

The Cirrus run for this commit shows "failed" status due to the manually cancelled macOS task, which I cancelled to save credits and since this is an ARM Linux-specific fix that didn't really need a macOS task running, as I've seen a passing macOS Cirrus task from just the last hour or so.

So, feel free to disregard the "failed" Cirrus build and note that the Arm Linux task specifically has gotten further with this fix than the ARM Linux task from just earlier today without the fix. Thanks.

EDIT: A re-run of the ARM Linux task finally passed in Cirrus CI! Woo!

@DeeDeeG
Copy link
Member Author

DeeDeeG commented May 16, 2024

With passing Cirrus CI and an Approve, I'm merging this! Thanks!

@DeeDeeG DeeDeeG merged commit 219392e into master May 16, 2024
104 of 105 checks passed
@DeeDeeG DeeDeeG deleted the Cirrus-fix-gem-install-fpm branch May 16, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants