Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build 1.103.2023040505 does not work for Intel macOS 13.3 #467

Closed
5 tasks done
etienne-miralytik opened this issue Apr 6, 2023 · 6 comments
Closed
5 tasks done
Labels
bug Something isn't working

Comments

@etienne-miralytik
Copy link

Thanks in advance for your bug report!

  • Have you reproduced issue in safe mode?
  • Have you used the debugging guide to try to resolve the issue?
  • Have you checked our FAQs to make sure your question isn't answered there?
  • Have you checked to make sure your issue does not already exist?
  • Have you checked you are on the latest release of Pulsar?

What happened?

I'v updated to 1.103.2023040505 and now Pulsar opens like this:
Bildschirmfoto 2023-04-06 um 11 31 58

Same story with safe mode.

Menu bar also looks very empty and I have very few options there, of which only the "Toggle Dev Tools" works.
Bildschirmfoto 2023-04-06 um 11 32 52

Pulsar version

1.103.2023040505

Which OS does this happen on?

🍎 macOS

OS details

macOS 13.3 (22E252)

Which CPU architecture are you running this on?

64-bit(x86_64)

What steps are needed to reproduce this?

Start Pulsar

Additional Information:

No response

@etienne-miralytik etienne-miralytik added the bug Something isn't working label Apr 6, 2023
@meadowsys
Copy link
Member

meadowsys commented Apr 6, 2023

Ah, yes, this would be mostly my fault, accidentally introduced this bug in a PR of mine ><

I believe we've identified the problem and fix on PR #464. You could stick to the latest regular release until that PR gets merged, then the problem should be resolved.

@etienne-miralytik etienne-miralytik changed the title Build 1.103.2023040505 does not for macOS 13.3 Build 1.103.2023040505 does not work for macOS 13.3 Apr 6, 2023
@etienne-miralytik
Copy link
Author

I've tried build 1.103.2023040600 from #464 and can confirm that this fixes the startup.

However I noticed that the "Pulsar" Menu changed, just that you know.

before:
Bildschirmfoto 2023-04-06 um 14 29 39

after:
Bildschirmfoto 2023-04-06 um 14 33 23

@etienne-miralytik etienne-miralytik changed the title Build 1.103.2023040505 does not work for macOS 13.3 Build 1.103.2023040505 does not work for Intel macOS 13.3 Apr 6, 2023
@mauricioszabo
Copy link
Contributor

Newer CI scripts are checking if the binary itself runs: see https://cirrus-ci.com/github/pulsar-edit/pulsar/build-and-test. On this Cirrus run, we can see that Silicon Mac is failing, so we protect ourselves against this kind of failure in the future.

As for the fix, I believe #454 fixes this right?

@etienne-miralytik
Copy link
Author

etienne-miralytik commented Apr 6, 2023

I actually tried the build from #454 and that had some pretty long start up time and I even got a message about this (application is taking very long, wait or close).
So that PR alone does not fix it properly for me.

@meadowsys
Copy link
Member

i18n has been reverted for now, and we will try to figure out all the issues on a seperate branch, so this issue should be resolved

@etienne-miralytik
Copy link
Author

I can confirm build 1.103.2023040620 fixes the issue as expected.

Note that https://download.pulsar-edit.dev/?os=intel_mac&type=mac_dmg still points to the broken build 1.103.2023040505.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants