Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decaffeinate develop spec #69

Merged
merged 2 commits into from
May 21, 2023

Conversation

2colours
Copy link
Contributor

@2colours 2colours commented Apr 8, 2023

Updated version of #25. No functional changes (this script hasn't been updated since the original PR) , semicolons readded.

@2colours 2colours mentioned this pull request Apr 8, 2023
12 tasks
Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing here, and overall the changes look good. Just pointed out a trivial, non-required change, but would likely be best to follow modern practices. But thanks for the contributions here

spec/develop-spec.js Show resolved Hide resolved
Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants