-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decaffeinate ci spec #65
Decaffeinate ci spec #65
Conversation
Supersedes #21. unused occurrances of |
@2colours One question I have concerns about, since the decaf PRs will be merged to main, will it cause issues that they are all separate PRs? Since these changes would be totally fine to be all on one PR. |
@confused-Techie I'm doing it like this for one simple reason: this is how @GuilleW left it behind. I can just checkout the branch, rebase it to the new one, play around with the differences that happened on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this PR looks good, there's one change that should be made, as it's generally the more performant option, and another change I wanted to address prior to merging.
Otherwise the tests are currently running and fingers crossed they look good, appreciate this a ton @2colours and sorry this last one took a bit to get to
- config path resolution based on file location - eliminate unnecessary variables along with the initialization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the important tests passing, and the changes here looking good I'll merge this one to the decaf branch.
No description provided.