Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: Actually sync yarn.lock #60

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Conversation

DeeDeeG
Copy link
Member

@DeeDeeG DeeDeeG commented Mar 8, 2023

This should make yarn.lock stable across multiple installs.

(Not sure why this diff wasn't part of the npm bump, but who knows?)

This should make yarn.lock stable across multiple installs.

(Not sure why this diff wasn't part of the npm bump, but who knows?)
@DeeDeeG
Copy link
Member Author

DeeDeeG commented Mar 8, 2023

Note, this technically overlaps with #57, but I think this is worth merging on its own.

This change is also committed in #57, but it is arguably a bit off-topic/out-of-scope there (?) and there is no diff between this branch and that one in terms of yarn.lock, so there should be no merge conflict if this one merges first.

#57 is currently a WIP PR with multiple changes needing to be done, and/or its scope reduced significantly to be mergeable, and so I don't think it'll be ready right away, whereas this is a really narrow one-file diff with a small diff at that.

If possible, I'd like to get the present PR merged here before syncing back to the core Pulsar repo again.

@DeeDeeG DeeDeeG mentioned this pull request Mar 8, 2023
Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI looks great, diff looks good, lets get this one merged!

@DeeDeeG
Copy link
Member Author

DeeDeeG commented Mar 9, 2023

Thank you for the review, merging this one, PR at core to bump the ppm submodule soon!

@DeeDeeG DeeDeeG merged commit 915cbf6 into master Mar 9, 2023
@Spiker985 Spiker985 deleted the actually-sync-yarn-lockfile branch March 19, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants