Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pulsar adjustments #6

Merged
merged 6 commits into from
Sep 23, 2022
Merged

Pulsar adjustments #6

merged 6 commits into from
Sep 23, 2022

Conversation

mauricioszabo
Copy link
Contributor

Basically, re-adjusting things here that are still pointing to "atom home" to start searching on "pulsar home"

confused-Techie
confused-Techie requested changes Sep 22, 2022
View reviewed changes
Copy link
Member

@confused-Techie confused-Techie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a single comment I think got missed. Otherwise this looks great.

EDIT:
Also might be a good idea to not, that this PR also allows support for a pulsar field in engines.

confused-Techie
confused-Techie approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for being so fast on my suggestion. This looks like a great contribution to me

@confused-Techie
Copy link
Member

Also I believe the reason that test is failing, is because its expecting a different return, which you've changed to The Pulsar or Atom engine range in the package.json file is invalid: because that's what's accurate, but the test expects The Atom engine range in the package.json file is invalid:. Should be able to just update the string it expects in the test to this

@confused-Techie
Copy link
Member

Yup, should just change the string expected in spec/publish-spec.coffee Line 77

@mauricioszabo mauricioszabo merged commit 052039a into master Sep 23, 2022
@mauricioszabo mauricioszabo deleted the pulsar-adjustments branch September 23, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@confused-Techie confused-Techie confused-Techie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mauricioszabo @confused-Techie