Use ppm as basename in getResourcePath checks #36
Conversation
|
Although while these changes are great, it occurs to me the decafe is done, and I'm in the process of reviewing. Not sure if you'd be open @jonian in opening another PR when I'm done merging those to apply these changes as well, but it is something I can do if needed. Otherwise I'll ping you when that process is over. As always thanks for the contribution! |
|
@confused-Techie It is no problem if this is merged first. I will redecaffeinate some files anyway. |
Glad to hear, in that case I'll go ahead and merge this one, thanks! |
|
This is a bit late but I think this pull request is not correct. I think it has caused this error. |
|
@sertonix is that possible with ppm submodule in pulsar being https://github.com/pulsar-edit/ppm/tree/2f184753bcaf71e32c8a977f6b2e1d548f8298bb? |
|
Also, I have pulsar installed from AUR, that uses this as a patch and I can install lang-gdscript without any issues. |
|
Ok, then this might fix the problem. Do you know how to update the submodule? |
|
@sertonix @confused-Techie in fact this PR fixes that error. I re-installed the latest binary without applying this fix and the result is: |
|
Glad to hear this PR is fixing the error. To update the submodule thatll have to be done as a PR to pulsar |
This fixes the issue with core packages not showing in settings view caused by the change of
apminstall folder toppmin pulsar-edit/pulsar#125.