Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump electron to 12 #2

Merged
merged 4 commits into from
Sep 3, 2022
Merged

Bump electron to 12 #2

merged 4 commits into from
Sep 3, 2022

Conversation

mauricioszabo
Copy link
Contributor

Basically, updating node version and renaming package

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some how missed this PR initially. But Looks good to me

@confused-Techie
Copy link
Member

While working on some tests, it looks like having this updated will help our bundled APM function properly. And since its been 15 days with no issues raised by the community, I'll go ahead and merge.

@confused-Techie confused-Techie merged commit 46d8338 into master Sep 3, 2022
@mauricioszabo mauricioszabo deleted the bump-electron-12 branch September 3, 2022 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants