-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update many dependencies #133
Conversation
Includes a yarn resolution to update one copy of [email protected]
Gets rid of an absolute metric ton of indirect dependencies.
Not needed after deduplicating lock-verify 2.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is my light approval.
Looking at just code wise, everything here seems to be totally fine, with the biggest change in deps being plist
which seems to only have any control in package-converted
and text-mate-theme
which if memory serves only effect migrating a TextMate theme to a Pulsar TextMate theme, which already is something we have talked about removing before, so it's functionality may not be a top priority.
Otherwise for some of these dependencies, I'd hope that automated testing would catch any issues present, but admittedly haven't found time to test. But I wanted to leave a review so that in any case we can merge this change, and let more rigorous testing occur in rolling, which would already be the case, since otherwise I don't see anything too obvious here that should give us any issue.
Gonna go ahead and merge this. Thanks for the review, even if it's a lite-approve I'm sure |
These were some low-hanging fruit for upgradable dependencies.
(And some slightly higher-hanging fruit, TBH, see the custom resolutions in
package.json
)Might as well, if we can, right?
Tests pass on my machine, and I can still install packages. (I tried
language-carp
andatom-ide-base
; Both had no obvious issues installing, in terms of being able to runppm install language-carp
orppm install atom-ide-base
without running into any errors on the CLI, at least.)Additional manual testing may be desirable, if we can get folks with the knowledge and time to thoroughly do so. Otherwise, we may just have to ask people to test it in the wild if we want to update these deps. In which case, best to have it in Rolling for a while and put out a call for testing there. Otherwise, we can perhaps try to call for testing of
ppm
itself with these changes before shipping it with Pulsar. But in any case, updating these seems like a good idea, IMO.Note: For documentation of Yarn's "resolutions" system, see: https://classic.yarnpkg.com/en/docs/selective-version-resolutions