Repository Cleanup #107
Merged
Repository Cleanup #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeeDeeG
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Looks good, a little cleanup is a good thing. I don't really expect us to be npm packing or npm publishing ppm any time soon, (npm pack is an option to prune files, but we can exclude from our electron-builder.js instead, so probably we'll do that) so package-lock.json and .npmignore can go.
The other files are pure cruft, can't think of a situation where we'd miss them.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking a closer look at this repo, now that the big ticket items have all been taken care of (eg Decaf, Async), I noticed quite a few outdated and useless files that had still remained.
I've gone ahead and removed the following files:
pnpm-workspace.yaml: We do not use PNPM in this repo officially.appveyor.yml: This repo has fully switched over to GitHub Actions../github/no-response.yml: We do not use probot.npmignore: We do not publish to NPM at all.package-lock.json: Since this repo has fully moved over to Yarn, this should no longer be needed.The bonus of PRs like this is to simply get rid of clutter in the repo, allowing a cleaner broad picture of the codebase as a whole.