Change atom strings to pulsar #4
Conversation
Hint: The links would need to be updated as well.
|
There is actually a question here as to if we want to keep the automatic reporting thing or not or if we just direct to GH issues. |
Co-authored-by: Daeraxa <[email protected]>
There was a problem hiding this comment.
This looks fantastic! And thanks to getting to this! We always appreciate the contribution.
So @Daeraxa while I do agree that we should remove the actually checking GitHub for existing issue thing, maybe we leave that to another PR to get this one through.
But I do absolutely agree on getting rid of that functionality, mostly due to generally being inaccurate, and when checking old Atom issues didn't do much to deter duplicate issues.
But as for this PR here, it's simple to the point and successfully updates everything that it looks like we need to. So I'd approve getting it merged!
|
Glad I could help. :) |
|
Alright, as it's been over 3 weeks with no other activity on this one to address the rest of the conversation I'll go ahead and merge this one. As it does address an issue on the main pulsar repo. Thanks again for contributing @mdibella-dev |
Fix to pulsar-edit/pulsar#347