Update Windows path registration #6
Conversation
Add the Pulsar install directory, and ppm bin directory to the user path - this should hopefully allow downstream steps to be able to shorthand `pulsar` instead of the full path
Because YAML
- Revert back to machine path over user path - Use `[System.Environment]SetEnvironmentVariable` and `[System.Environment]GetEnvironmentVariable` methods
- `/currentuser` picks the Appdata\Local location instead of Program Files - `/S` is the silent flag - `-wait` is needed otherwise we'd move on before the editor was installed
Just to be absolutely sure that it knows it's a directory
|
I had to update the test to split the windows test step from the Linux and macOS step. I don't know if that will have an effect on downstream steps. Especially when paired with xvfb. |
There was a problem hiding this comment.
I'm approving because the changes look solid, and based on our own tests seem to work.
Although prior to merging I think it'd be important to test this PR's changes on an actual package to see what kind of affect it has on testing for Windows.
Then we can use that to determine if this PR includes breaking changes or not, since otherwise I think we should get this one merged no matter what.
Thanks a ton for the contribution, this looks awesome!
|
Currently trying this out on a branch for |
Following the doc available [here](https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#adding-a-system-path) should hopefully allow us to have access to the PATH immediately within the same job
|
So, it seems like it was simpler than previously thought to get the Windows PATH fixed for CI - just had to find the right documentation which is definitely easier said than done |
There was a problem hiding this comment.
✅
Other than wanting the whitespace-only change nullified on the test.yml file, I can register a "lite-approve" on this.
I don't feel qualified to properly approve since I don't understand whether or how the GITHUB_PATH stuff all works. But if you've tested this, I appreciate that. So I am lightly in favor of merging this if it moves this repo forward.
Co-authored-by: DeeDeeG <[email protected]>
As of 1.102.0, macOS is now signed
|
When I looked, I found this which I think is our macOS problem when actually running on CIs such as pulsar-edit/snippets#10 and Spiker985/x-terminal-reloaded#14 |
- Validate `/usr/local/bin` exists, and make it otherwise - Change the `pulsar` symlink to `pulsar.sh` - Add a commented symlink for ppm (just in case) - however, `pulsar -p` or `pulsar --package` should handle fine without it
- Change to recommending `coactions/setup-xvfb` over `GabrielBB/xvfb-action` as the latter appears unmaintained, and needs updated - Preemptively update the version to match the expected release version
Add the Pulsar install directory, and ppm bin directory to the user path - this should hopefully allow downstream steps to be able to shorthand
pulsarinstead of the full path