-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create rules-info-channel.md #215
base: main
Are you sure you want to change the base?
Conversation
This is a update to the rules(and potentionally a renaming to rules-and-info). This better organizes that channel and gets rid of unnecessary messages that were pings to make sure people saw things in there and remembered to join roles. As well as adding one and changing the description of the other. I'd also like to propose this as the starting point to also discuss the colors of those roles for accessibility purposes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I was asked to post the stuff I was saying in the Discord about trying to find some accessible (contrasting, color-blindness compatible) colors for all the roles. Here's that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From Discord:
I think we do have a bit of overlap/convergence on pupley-blue colors.
I'm trying some color-blindness simulating tools, and I'm realizing that red-colorblindness can lead to "purple - red = blue" and a convergence on some bluish colors that are pretty similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@backend
is a slightly darker purple than@team
at the moment.@Documentation
and@cmty-pkgs
are two blue shades that converge a bit with the purple shades under red-colorblindness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might have to research an overall colorblindness-safe color palette and draw only from those if we're shooting for strong accessibility.
(Or at least I expect this would make finding them faster/easier and harder to mess up.)
[ . . . ]
This tool seems really helpful, IMO:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking out the tool and seeing what I (and it) can do.
(I started by locking in the purple color that was recently set for
@team
role here on the Discord, and working around that to find additional, contrasting colors.)Here are two example palettes that look pretty good (to me) for simulated red/green/blue color-blindnesses, and I checked the first one for greyscale color-blindness and simulated loss-of-contrast viewing (where color and brightness differences are compressed toward a uniform grey.)
(I didn't research what types of color-blindness there are IRL yet, but apparently red/green is the most common, blue blindness is rare, dunno if greyscale-only color-blindness is a thing.)
I'm disappointed it's limited to 5 colors, but it works really well (in terms of its user interface and amount of easily-actionable feedback), so it's a great start, IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to pop in and say there's a tool that makes palettes with more than 5 colors somewhat easier:
Example expanded palettes of 8 colors:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I'm having a lot of doubt though with some of the roles. I know I named them trying to cover all our bases(and a lot of them are solely placeholders until others came up with better names when we scrambled to get everything together).
Like in a ideal world(with renames) I'd suggest these in this order w/renames and different colors if needed. Obviously lumping in Dee's suggestion of the separation that we may not be the same on github in perms:
- Team
- Needs rename to reflect experienced and well trusted contributors
- Admins (Discord)
- Mods (Discord)
- Core
- Documentation
- Backend
- Developer (needs rename imo....something more specific would be ideal)
- Cmty_pkgs (again another I put as a placeholder originally that was a result of overthinking to make sure people didn't confuse w/our core packages)
- Linux
- Mac
- Windows
Now those ARE up for debate but that's my more definitive list imo. Bot roles not included bc these are a given and probably need to be moved to just below admins for sake of what it does w/bots. Just bc it CAN cause issues if any of the original ones are still used, which I doubt for the most part lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dunno about renaming, since less change is better and none of them struck me as needing renaming.
The @team
role is what it is, either it refers to folks who do internal deliberations before presenting to the broader group and who are pretty much collectively responsible for admin (i.e. "the team" basically) or it isn't and we shouldn't have the role and go back to managing #team
channel the way we were before. Either way, IMO. (Not that I would want go and change it again without everyone agreeing first. Less change unless it's outright broken, IMO.)
Maybe there's some other option I'm not thinking of, but it doesn't all matter a ton. It mostly just think it needs to be functional, which it is currently.
I do think we can get 7 or 8 good distinct colors, though. And we can prefer to use the most similar ones to the existing ones where possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I mention the team bit because of what @confused-Techie has mentioned and I think maybe even @Daeraxa? That it being explicitly named team can seem a bit exclusionary and contradictive to it's true nature. But I feel like the list I came up w/in that last post is the one to focus on. Albeit w/out recoloring admins/mods since I feel having team higher up negates it and is a good idea. Mods/Admins are still pingable like I've said a few times so yea.
I just see team as the general ping for help, but ideally people would go for the actual team over that bit. I'm just overthinking and wanting to fix a few things I feel were massive leftovers from my initial rushed setup of the discord and other things....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd warn against scope creep bringing up renaming and new teams during a PR, nothing wrong with it, just makes it harder to keep a solid goal in mind.
As for the other teams, I'm actually very actively against, any kind of coloration to the "Linux", "Windows", and "macOS" roles. If anything it may be prudent to bring up separately about disabling the general public from pinging these roles. I don't think these roles should stand out in any particular way, they already don't appear on the sidebar, and are nearly unused. Except for the rare instance we need to ping it for help in testing something. But as our server grows, there's now far to many people attached to those pings that are not present during the day to day, that the odd time it gets pinged for no reason, it seems to leave a few days of messages asking why they were pinged. So I don't think these roles should stand out at all, in any way, so they shouldn't be included in any kind of re-colorizing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some comments here about some suggestions. Mostly touching on the language being used, and in some cases the meaning behind them. Overall this looks great though
Yea I'll take a look at it. Most of it was literally pulling directly from the channel as is right now and reorganizing it. |
Co-authored-by: confused_techie <[email protected]>
Co-authored-by: confused_techie <[email protected]>
Co-authored-by: confused_techie <[email protected]>
Co-authored-by: confused_techie <[email protected]>
Moving roles content to the file for clarity sake. Further changes to that file incoming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaosine Thanks a ton for working with my suggested changes.
Overall things here look really good. Now we just need to settle on the colours themselves. But overall rad work
So @kaosine taking another look at this, while wording and documentation isn't my best strong suite, I'd rather leave that to those that it is. But speaking on the existing changes, I'd be on board with getting this one merged, although I'd like to remove the Otherwise, if you feel it's needed to get the colours documented here, we can go ahead and wait on that to pan out. Possibly by putting together some options for people to choose from utilizing the suggested resources from DeeDee? Or even just trying to put together a poll for those existing options DeeDee had created, whatever you feel might be best in this area. |
Yea if we go the route of colors I'd just like to focus on the conflicting ones I noticed and keep the rest. So admin, mod, core and backend. With the below reasoning:
Otherwise I can just remove the color bits for now and move forward. I'd like everyone's opinion but not sure how to get more eyes on this one other than just you two. I'd like to hear what option is preferred and we'll move forward with that. |
This is a update to the rules(and potentially a renaming to rules-and-info). This better organizes that channel and gets rid of messages that should've been placed elsewhere.
This also adds the new team role(for experienced contributors that we can trust to support and answer questions of other users). I'd also like to propose this as the starting point to also discuss the colors of those roles for accessibility purposes.
Since beyond bots we've added to help add us these are the current colors and organization of those roles:
If we could boost ourselves to level 2 and/or get the discovery we might be able to label them differently w/images instead. But we esp need to fix colors as we now have 3 different roles that are purple and need fixing at this point as part of this.
Discussion and changes are welcome to this.