Pulp rpm package #34
Closed
Pulp rpm package #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So what is the natural key for an RPM? nevra, digest? That would be the one to use. |
|
If the checksum is needed, it should also be sufficient (in this context). |
Merged
|
Can you rebase this? It were easier to look at it if it didn't contain all the other changes already merged. |
cognifloyd
force-pushed
the
pulp_rpm_package
branch
from
e621e7d to
29809e3
Compare
|
We need this module as well. Can I somehow help you with this PR? |
|
We need this as well. Can someone pick this up? |
|
Sorry. Since I wrote this, I changed jobs and haven't had time to pick it back up. Please run with what I've got. I won't have time to touch this for the foreseeable future. |
ziegenberg
added a commit
to ziegenberg/squeezer
that referenced
this pull request
Jul 13, 2022
Based on PR pulp#34 on the work by Jacob Floyd (@cognifloyd). Co-authored-by: Jacob Floyd <[email protected]> Signed-off-by: Daniel Ziegenberg <[email protected]>
|
I picked up your changes and based my PR #105 on them. Going forward from there. |
ziegenberg
added a commit
to ziegenberg/squeezer
that referenced
this pull request
Jul 13, 2022
Based on PR pulp#34 on the work by Jacob Floyd (@cognifloyd). Co-authored-by: Jacob Floyd <[email protected]> Signed-off-by: Daniel Ziegenberg <[email protected]>
|
I suggest closing this in favour of #105. |
ziegenberg
added a commit
to ziegenberg/squeezer
that referenced
this pull request
Aug 1, 2022
Based on PR pulp#34 on the work by Jacob Floyd (@cognifloyd). Co-authored-by: Jacob Floyd <[email protected]> Signed-off-by: Daniel Ziegenberg <[email protected]>
mnasiadka
pushed a commit
to mnasiadka/squeezer
that referenced
this pull request
Feb 12, 2024
Based on PR pulp#34 on the work by Jacob Floyd (@cognifloyd). Co-authored-by: Jacob Floyd <[email protected]> Signed-off-by: Daniel Ziegenberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on top of #32
It is not functional yet. I'm not sure how this should work. Unlike FileContent, you can't look up with
relative_path.