Prepend Content model hierarchy with _ #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump the pulpcore-plugin dep to b15, it should fix this issue. |
CodeHeeler
force-pushed
the
issue-4206
branch
from
43bc9ac to
f864850
Compare
dralley
requested changes
Jan 2, 2019
There was a problem hiding this comment.
In addition to the inline comment, "artifacts" on these two lines should be fixed
https://github.com/pulp/pulp_python/blob/master/pulp_python/app/serializers.py#L226
https://github.com/pulp/pulp_python/blob/master/pulp_python/app/serializers.py#L242
pulp_python/app/models.py
Outdated
| @@ -152,11 +152,11 @@ def __str__(self): | |||
| e.g. <PythonPackageContent: shelf-reader [version] (whl)> | |||
|
|
|||
| """ | |||
| return '<{obj_name}: {name} [{version}] ({type})>'.format( | |||
| return '<{obj_name}: {name} [{version}] ({_type})>'.format( | |||
There was a problem hiding this comment.
This actually doesn't need to be changed, it maps to packagetype not the underlying "_type" field.
CodeHeeler
force-pushed
the
issue-4206
branch
3 times, most recently
from
7f83748 to
f6c14a6
Compare
Prepend all pulpcore model fields in the Content model hierarchy with _ and do the same for all plugins reliant on them. Required PR: pulp/pulp#3798 re #4206 https://pulp.plan.io/issues/4206
dralley
approved these changes
Jan 8, 2019
|
@CodeHeeler @asmacdo , Test failures are due to an upstreah aiohttp issue, not anything we're doing. I downgraded aiohttp locally and everything passes now. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepend all pulpcore model fields in the Content model hierarchy with _
and do the same for all plugins reliant on them.
Required PR: pulp/pulp#3798
re #4206
https://pulp.plan.io/issues/4206