Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Changelog #2012

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Update Changelog #2012

merged 1 commit into from
Oct 31, 2024

Conversation

pulpbot
Copy link
Member

@pulpbot pulpbot commented Oct 30, 2024

No description provided.

CHANGES.md Outdated

---

# ## 0.21.8 (2024-08-14) {: #0.21.8 }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedro-psb
Looks familiar?

The use of ## (h2) and #### (h4) without ### (h3) is because we use that level for the plugin api heading, right? Do you think that may be related to what we see here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn.
Yeah, this header skip is to enable those sub-categories. I don't see how this could interefere (but I'm clueless about this bug, so that's not a helpful insight)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't strictly have the same format on all old branches and somwhere a regex for "## " matches part of "### " and boom there we are.

@mdellweg mdellweg enabled auto-merge (rebase) October 31, 2024 14:00
@mdellweg mdellweg merged commit ac0cacb into main Oct 31, 2024
12 checks passed
@mdellweg mdellweg deleted the changelog/update branch October 31, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants