Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature validation depends on an externally provided keyring #1086

Closed
mdellweg opened this issue Jul 5, 2022 · 0 comments · Fixed by #1088
Closed

Signature validation depends on an externally provided keyring #1086

mdellweg opened this issue Jul 5, 2022 · 0 comments · Fixed by #1088

Comments

@mdellweg
Copy link
Member

mdellweg commented Jul 5, 2022

This is bad for several reasons:

  • The keyring must be provisioned and made available on all pulp nodes/containers/service units (installer nightmare).
  • The repository serializer references a local file on the server to select the keyring (bad api).
  • It is impossible to provide a key to verify against via the api.
  • It is impossible to use an ephemeral keyring in the tests.

The proposed solution is to add a (text-)field on the repository that can hold a (maybe multiple) private key. Verification of an uploaded signature will then only depend on information in the applications database.

mdellweg added a commit to mdellweg/pulp_ansible that referenced this issue Jul 5, 2022
mdellweg added a commit to mdellweg/pulp_ansible that referenced this issue Jul 5, 2022
mdellweg added a commit to mdellweg/pulp_ansible that referenced this issue Jul 5, 2022
mdellweg added a commit to mdellweg/pulp_ansible that referenced this issue Jul 5, 2022
mdellweg added a commit to mdellweg/pulp_ansible that referenced this issue Jul 6, 2022
mdellweg added a commit to mdellweg/pulp_ansible that referenced this issue Jul 6, 2022
mdellweg added a commit to mdellweg/pulp_ansible that referenced this issue Jul 6, 2022
mdellweg added a commit to mdellweg/pulp_ansible that referenced this issue Jul 7, 2022
mdellweg added a commit to mdellweg/pulp_ansible that referenced this issue Jul 7, 2022
mdellweg added a commit to mdellweg/pulp_ansible that referenced this issue Jul 7, 2022
mdellweg added a commit to mdellweg/pulp_ansible that referenced this issue Jul 8, 2022
mdellweg added a commit to mdellweg/pulp_ansible that referenced this issue Jul 12, 2022
mdellweg added a commit to mdellweg/pulp_ansible that referenced this issue Jul 12, 2022
mdellweg added a commit to mdellweg/pulp_ansible that referenced this issue Jul 12, 2022
mdellweg added a commit to mdellweg/pulp_ansible that referenced this issue Jul 14, 2022
mdellweg added a commit to mdellweg/pulp_ansible that referenced this issue Jul 15, 2022
mdellweg added a commit to mdellweg/pulp_ansible that referenced this issue Jul 15, 2022
mdellweg added a commit that referenced this issue Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant