Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error reporting from openapi calls #21

Merged
merged 1 commit into from
Oct 25, 2020

Conversation

mdellweg
Copy link
Member

In case the library can identify the error, there is no use in dumping a
complete stack trace. Introduced OpenAPIError exception.

@pulpbot
Copy link
Member

pulpbot commented Oct 25, 2020

WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue.

In case the library can identify the error, there is no use in dumping a
complete stack trace. Introduced OpenAPIError exception.
@daviddavis
Copy link
Contributor

FYI, I started looking at the failures. They're also happening on develop. I couldn't reproduce locally though with my dev server. I think there might be something in the single container that's causing the failures...?

@mdellweg
Copy link
Member Author

I added more error output on failed tasks. So in a way, we were lucky here. XD
https://github.com/pulp/pulp-cli/pull/21/checks?check_run_id=1304812030#step:6:224

@daviddavis
Copy link
Contributor

Here we go:

aio-libs/aiohttp#5110
aio-libs/aiohttp#5118

@daviddavis
Copy link
Contributor

I opened pulp/pulpcore#984 so we're not completely unpinned.

I also kicked off a new pulp-oci-images publish job.

@mdellweg
Copy link
Member Author

So it has been fixed upstream... ?!

@mdellweg mdellweg merged commit e44418c into pulp:develop Oct 25, 2020
@mdellweg mdellweg deleted the error_reporting branch October 25, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants